Messages in this thread Patch in this message | | | Subject | [Patch] Fix typo in drivers/isdn/hisax/q931.c | From | Eric Sesterhenn <> | Date | Mon, 05 Jun 2006 21:06:14 +0200 |
| |
hi,
this fixes coverity bug #517. Since IESIZE is greater than IESIZE_NI1 we might run past the end of ielist_ni1. This fixes it by using the proper IESIZE_NI1 define.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.17-rc5/drivers/isdn/hisax/q931.c.orig 2006-06-05 20:57:11.000000000 +0200 +++ linux-2.6.17-rc5/drivers/isdn/hisax/q931.c 2006-06-05 20:57:50.000000000 +0200 @@ -1402,12 +1402,12 @@ dlogframe(struct IsdnCardState *cs, stru } /* No, locate it in the table */ if (cset == 0) { - for (i = 0; i < IESIZE; i++) + for (i = 0; i < IESIZE_NI1; i++) if (*buf == ielist_ni1[i].nr) break; /* When not found, give appropriate msg */ - if (i != IESIZE) { + if (i != IESIZE_NI1) { dp += sprintf(dp, " %s\n", ielist_ni1[i].descr); dp += ielist_ni1[i].f(dp, buf); } else
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |