Messages in this thread | | | From | Michael Buesch <> | Subject | Re: debugging "irq 7: nobody cared" in my module | Date | Mon, 5 Jun 2006 18:47:59 +0200 |
| |
On Monday 05 June 2006 18:11, Thomas Andrews wrote: > On Mon, Jun 05, 2006 at 02:51:32PM +0200, Thomas Andrews wrote: > > > What can cause "irq x: nobody cared" ? On exit from my IRQ handler, I am > > checking to make sure that there are no residual/pending unhandled > > events on exit. Here is part of my handler: > > > > irqreturn_t scx200_acb_irq(int irq_no, void *dev_id, struct pt_regs *regs) > > { > > struct scx200_acb_iface *iface = dev_id; > > unsigned long flags; > > spin_lock_irqsave(lock, flags); > > if (inb(ACBST)) { > > // tasklet_schedule(&iface->tasklet); > > scx200_acb_machine(iface, inb(ACBST)); > > if (iface->state == state_idle) /* Finished */ > > wake_up_interruptible(&iface->acb_queue); > > } else { > > /* Should never get here */ > > printk("causeless IRQ!\n"); > > /* Reset the ACB to clear any pending IRQ */ > > outb((inb(ACBCTL2) & 0xfe), ACBCTL2); > > outb((inb(ACBCTL2) | 0x01), ACBCTL2); > > } > > /* Check to see if some event was not handled */ > > if (inb(ACBST) & 0xBC) > > printk("============== ACBST=%#x ===============\n",inb(ACBST)); > > spin_unlock_irqrestore(lock, flags); > > return IRQ_RETVAL(0); > > } > > I've found the problem now. The last line is wrong - it should read: > > return IRQ_RETVAL(IRQ_HANDLED);
No, either return IRQ_HANDLED; or return IRQ_RETVAL(boolean);
You returned the boolean 0, which is "false".
-- Greetings Michael. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |