lkml.org 
[lkml]   [2006]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH]add ext3_fileblk_t for file relative offset
On Jun 28, 2006  22:31 +0900, sho@tnes.nec.co.jp wrote:
> In Mingming's patch set, the single type `ext3_fsblk_t' deal with two
> different values, which are file relative offset and filesystem
> relative offset. I think it is confusing.
>
> Therefore I added "ext3_fileblk_t" for file relative offset.
> It makes maintenance easier and code clearer if file size
> needs to be larger.
> ext3_fileblk_t is unsigned long which is the maximum size of
> current type for file relative offset.

I think this is a good idea and support its inclusion into the patch set.
It also managed to find one (harmless) bug in the code.

> int ext3_get_blocks_handle(handle_t *handle, struct inode *inode,
> - sector_t iblock, unsigned long maxblocks,
> + ext3_fileblk_t iblock, unsigned long maxblocks,

iblock shouldn't have been a sector_t.


Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-30 09:48    [W:0.047 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site