Messages in this thread | | | Subject | Re: SA_TRIGGER_* vs. SA_SAMPLE_RANDOM | From | Thomas Gleixner <> | Date | Fri, 30 Jun 2006 16:00:07 +0200 |
| |
David,
On Thu, 2006-06-29 at 14:17 -0700, David Miller wrote: > Since SA_SAMPLE_RANDOM is defined as "SA_RESTART", it > could be just about any value. > > On sparc, it's value is "2", so it aliases some of > the SA_TRIGGER_* defines the new genirq code adds. > And therefore we get a bunch of these on sparc64: > > [ 16.650540] setup_irq(2) SA_TRIGGERset. No set_type function available > > (btw: missing space in the kernel log message between 'SA_TRIGGER' > and 'set' :-) > > I can't see any reason why SA_SAMPLE_RANDOM is set to > a signal mask value, or why IRQ flags are defined in > linux/signal.h :-) > > Anyways, probably the best bet for now is to define > SA_SAMPLE_RANDOM explicitly to some value instead of > relying on the arbitrary platform definition of SA_RANDOM. > > Ingo could you cook up and submit a patch which does this? > Thanks.
We have the same hassle with SA_INTERRUPT. The question arises, if we should move the SA_XX flags for interrupts completely out of the signal SA name space. Rename to IRQ_xxx and put them into interrupt.h.
tglx
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |