Messages in this thread | | | From | "Takashi Sato" <> | Subject | Re: [Ext2-devel] [RFC 1/2] ext3: enlarge blocksize and fix rec_lenoverflow | Date | Thu, 29 Jun 2006 19:46:52 +0900 |
| |
Hi,
> On Jun 28, 2006 17:50 +0200, Johann Lombardi wrote: >> ext2/ext3_dir_entry_2 has a 16-bit entry(rec_len) and it would overflow >> with 64KB blocksize. This patch prevent from overflow by limiting >> rec_len to 65532. > > Having a max rec_len of 65532 is rather unfortunate, since the dir > blocks always need to filled with dir entries.
Oh, that's right.
> 65536 - 65532 = 4, and > the minimum ext3_dir_entry size is 8 bytes. I would instead make this > maybe 64 bytes less so that there is room for a filename in the "tail" > dir_entry.
What does "64 bytes" mean? Do you mean that the following dummy entry should be added at the tail of the directory block?
struct ext3_dir_entry_2 { __le32 inode = 0 __le16 rec_len = 16 __u8 name_len = 4 __u8 file_type = 0 char name = "dir_end" };
Cheers, sho - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |