Messages in this thread | | | Date | Thu, 29 Jun 2006 11:40:31 +0200 | From | "Jan Beulich" <> | Subject | Re: [PATCH]microcode update driver rewrite - takes 2 |
| |
>>> Shaohua Li <shaohua.li@intel.com> 29.06.06 11:15 >>> >On Thu, 2006-06-29 at 11:03 +0200, Jan Beulich wrote: >> I'm not having a problem removing the messages if the current state can be obtained >> elsewhere. >> >> Looking at the patch I see at least one problem (in more than one place) - before >> accessing data, you should check that the relevant piece to be read is entirely within >> range. You should not (as done at least once) rely on copy_from_user() failing - the >> data may be readable, but out of bounds wrt. the information in the headers (or the >> header sizes themselves). >Can you please give me more details? I had a lot of checks there if the >size is incorrect.
Ah, yes, I missed the sanity checking function. That seems to take care of what I thought was missing elsewhere.
Jan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |