Messages in this thread | | | Date | Thu, 29 Jun 2006 19:13:32 -0700 | From | Greg KH <> | Subject | Re: USB driver for Sierra Wireless EM5625/MC5720 1xEVDO modules |
| |
On Wed, Jun 28, 2006 at 07:27:27PM -0400, Andy Gay wrote: > I have adapted the modified Airprime driver that Greg posted a few weeks > ago to add support for these 2 modules. > > That driver works for these modules if the USB IDs are added, and fixes > the throughput problems in the earlier driver. I had to make some > changes though - > > - there's a memory leak because the transfer buffers are kmalloc'ed > every time the device is opened, but they're never freed; > > - these modules present 3 bulk EPs, the 2nd & 3rd can be used for > control & status monitoring while data transfer is in progress on the > 1st EP. This is useful (and necessary for my application) so we need to > increase the port count. > > So what should I do next? I see a few possibilities, assuming anyone is > interested in this: > > - I could post a diff from Greg's driver. But I don't have hardware to > test whether my changes will break it for the other devices that it > supports; > > - I could post it as a new driver for just these 2 modules, using some > other name; > > - I could post it as a replacement for Greg's driver (which isn't yet in > the official sources, I think), including all the USB IDs, if someone > can test it for the other devices.
or: - send a patch against 2.6.17 that is my changes + your fixes to actually make it work.
My patch was just a "throw it out there and see what works or not", as I don't even have the device to test it with.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |