lkml.org 
[lkml]   [2006]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 33 of 39] IB/ipath - read/write correct sizes through diag interface
    Date
    From
    We must increment uaddr by size we are reading or writing, since it's
    passed as a char *, not a pointer to the appropriate size.

    Signed-off-by: Dave Olson <dave.olson@qlogic.com>
    Signed-off-by: Bryan O'Sullivan <bryan.osullivan@qlogic.com>

    diff -r 8fbb5d71823a -r a7c1ad1e090b drivers/infiniband/hw/ipath/ipath_diag.c
    --- a/drivers/infiniband/hw/ipath/ipath_diag.c Thu Jun 29 14:33:26 2006 -0700
    +++ b/drivers/infiniband/hw/ipath/ipath_diag.c Thu Jun 29 14:33:26 2006 -0700
    @@ -115,7 +115,7 @@ static int ipath_read_umem64(struct ipat
    goto bail;
    }
    reg_addr++;
    - uaddr++;
    + uaddr += sizeof(u64);
    }
    ret = 0;
    bail:
    @@ -154,7 +154,7 @@ static int ipath_write_umem64(struct ipa
    writeq(data, reg_addr);

    reg_addr++;
    - uaddr++;
    + uaddr += sizeof(u64);
    }
    ret = 0;
    bail:
    @@ -192,7 +192,8 @@ static int ipath_read_umem32(struct ipat
    }

    reg_addr++;
    - uaddr++;
    + uaddr += sizeof(u32);
    +
    }
    ret = 0;
    bail:
    @@ -231,7 +232,7 @@ static int ipath_write_umem32(struct ipa
    writel(data, reg_addr);

    reg_addr++;
    - uaddr++;
    + uaddr += sizeof(u32);
    }
    ret = 0;
    bail:
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-06-29 23:50    [W:0.020 / U:218.288 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site