lkml.org 
[lkml]   [2006]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/3] SELinux: Extend task_kill hook to handle signals sent by AIO completion
    From
    Date
    On Thu, 2006-06-29 at 11:43 -0400, James Morris wrote:
    > On Thu, 29 Jun 2006, Stephen Smalley wrote:
    >
    > > On Wed, 2006-06-28 at 17:16 -0700, Chris Wright wrote:
    > > > > + void (*task_getsecid) (struct task_struct * p, u32 * secid);
    > > >
    > > > Why not just:
    > > > u32 (*task_getsecid) (struct task_struct *p);
    > >
    > > That's fine, although we should then change the SELinux exports as well
    > > to be consistent (and convert them all to secid rather than sid or
    > > ctxid, and eliminate duplication there that has crept in). That can be
    > > done by later patch.
    >
    > My preference is to leave it as-is, because these interfaces generally
    > return only error values. IMHO, it's always much clearer that way in any
    > case, for APIs like this.

    Ok, fine with me.

    --
    Stephen Smalley
    National Security Agency

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-06-29 17:54    [W:0.025 / U:1.600 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site