Messages in this thread | | | Date | Wed, 28 Jun 2006 17:50:48 +0200 | From | Johann Lombardi <> | Subject | Re: [RFC 1/2] ext3: enlarge blocksize and fix rec_len overflow |
| |
Hi Takashi,
> ext2/ext3_dir_entry_2 has a 16-bit entry(rec_len) and it would overflow > with 64KB blocksize. This patch prevent from overflow by limiting > rec_len to 65532.
In empty_dir(), offset is incremented by de->rec_len until it reaches inode->i_size. I think bad things will happen with a 64kB blocksize since the records no longer span the entire directory block.
AFAICS, there's a similar issue with bh->b_size in ext3_delete_entry().
Cheers,
Johann - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |