lkml.org 
[lkml]   [2006]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 20/20] honor r/w changes at do_remount() time
    Quoting Herbert Poetzl (herbert@13thfloor.at):
    > On Wed, Jun 28, 2006 at 06:19:35AM +0100, Al Viro wrote:
    > > On Tue, Jun 27, 2006 at 03:14:57PM -0700, Dave Hansen wrote:
    > > >
    > > > Originally from: Herbert Poetzl <herbert@13thfloor.at>
    > > >
    > > > This is the core of the read-only bind mount patch set.
    > > >
    > > > Note that this does _not_ add a "ro" option directly to
    > > > the bind mount operation. If you require such a mount,
    > > > you must first do the bind, then follow it up with a
    > > > 'mount -o remount,ro' operation.
    > >
    > > I guess the fundamental problem I have with that approach is that it's
    > > a cop-out - we just declare rw state of vfsmount independent from that
    > > of filesystem and add a "if a flag is set, act upon vfsmount".
    >
    > IMHO the read only check has to be done twice, i.e
    > once for the superblock and a second time for the
    > particular vfs mount, similar, the procfs mounts
    > entry shows the combination (logical and) of the
    > write ability ...

    Shouldn't the vfsmount rw flag being set imply superblock rw?

    -serge
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-06-28 17:05    [W:0.025 / U:151.704 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site