lkml.org 
[lkml]   [2006]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 10/13: eCryptfs] Mmap operations
    Hi,

    Sorry for the late comment...

    On 5/13/06, Phillip Hellewell <phillip@hellewell.homeip.net> wrote:
    > +static struct page *ecryptfs_get1page(struct file *file, int index)
    > +{
    > + struct page *page;
    > + struct dentry *dentry;
    > + struct inode *inode;
    > + struct address_space *mapping;
    > +
    > + dentry = file->f_dentry;
    > + inode = dentry->d_inode;
    > + mapping = inode->i_mapping;
    > + page = read_cache_page(mapping, index,
    > + (filler_t *)mapping->a_ops->readpage,
    > + (void *)file);
    > + if (IS_ERR(page))
    > + goto out;
    > + wait_on_page_locked(page);

    Why no check for PageUptodate?

    > +out:
    > + return page;
    > +}
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-06-28 16:19    [W:0.030 / U:32.968 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site