lkml.org 
[lkml]   [2006]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[Patch] Missing statement in drivers/media/dvb/frontends/cx22700.c
    From
    Date
    hi,

    stumbled over this because of coverity (id #492),
    seems like we are missing a return statement here and fail
    to do proper bounds checking. If this assumption is false
    we should at least change the identation to make it clear

    Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>

    --- linux-2.6.17-git11/drivers/media/dvb/frontends/cx22700.c.orig 2006-06-28 01:40:49.000000000 +0200
    +++ linux-2.6.17-git11/drivers/media/dvb/frontends/cx22700.c 2006-06-28 01:41:04.000000000 +0200
    @@ -134,6 +134,7 @@ static int cx22700_set_tps (struct cx227
    return -EINVAL;

    if (p->code_rate_LP < FEC_1_2 || p->code_rate_LP > FEC_7_8)
    + return -EINVAL;

    if (p->code_rate_HP == FEC_4_5 || p->code_rate_LP == FEC_4_5)
    return -EINVAL;

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-06-28 01:47    [W:3.636 / U:0.508 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site