![]() | |||||||||||||
Messages in this thread |
On Tue, 2006-06-27 at 00:02 +0200, Adrian Bunk wrote: > This patch makes the needlessly global mtdpart_setup() static. > > Signed-off-by: Adrian Bunk <bunk@stusta.de> > > --- linux-2.6.17-mm2-full/drivers/mtd/cmdlinepart.c.old 2006-06-26 23:18:39.000000000 +0200 > +++ linux-2.6.17-mm2-full/drivers/mtd/cmdlinepart.c 2006-06-26 23:18:51.000000000 +0200 > @@ -346,7 +346,7 @@ > * > * This function needs to be visible for bootloaders. > */ > -int mtdpart_setup(char *s) > +static int mtdpart_setup(char *s) Patch lacks sufficient explanation. Explain the relevance of the comment immediately above the function declaration, in the context of your patch. Explain your decision to change the behaviour, but not change the comment itself. Think. Or you will be replaced with a small shell script. -- dwmw2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2006-06-27 13:51 [from the cache] ©2003-2008 | |||||||||||||