Messages in this thread | | | Date | Tue, 27 Jun 2006 19:35:20 +1000 | Subject | Re: [Suspend2][ 0/2] Cryptoapi deflate fix. | From | Herbert Xu <> |
| |
On Tue, Jun 27, 2006 at 05:02:46PM +1000, Nigel Cunningham wrote: > > Ok. Sorry for my wonky memory then :)
No problems.
> Yes, I'm always feeding it PAGE_SIZE chunks and compressing each page > separately. It's a long time since I looked at or thought about this, so I'll > spend some more time getting it fresh in my head if you like.
If you could give me a minimal test case to work with that'd be great.
> I just left Marc's original code as it was, so I'm not completely sure, but I > guess it's because we want lowmem.
The question is why do you need lowmem? It doesn't appear to be obvious by looking at the code.
> > This is a double-free of local_buffer. > > Is that from our previous correspondence? I can't find anything like it now.
Yes, that was from a year ago before you fixed the code :) Feel free to resubmit this once you've addressed the vmalloc question.
Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |