Messages in this thread Patch in this message | | | From | NeilBrown <> | Date | Tue, 27 Jun 2006 17:05:15 +1000 | Subject | [PATCH 002 of 12] md: Set desc_nr correctly for version-1 superblocks. |
| |
This has to be done in ->load_super, not ->validate_super
Without this, hot-adding devices to an array doesn't always work right - though there is a work around in mdadm-2.5.2 to make this less of an issue.
### Diffstat output ./drivers/md/md.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff .prev/drivers/md/md.c ./drivers/md/md.c --- .prev/drivers/md/md.c 2006-06-27 12:15:17.000000000 +1000 +++ ./drivers/md/md.c 2006-06-27 12:17:32.000000000 +1000 @@ -1064,6 +1064,11 @@ static int super_1_load(mdk_rdev_t *rdev if (rdev->sb_size & bmask) rdev-> sb_size = (rdev->sb_size | bmask)+1; + if (sb->level == cpu_to_le32(LEVEL_MULTIPATH)) + rdev->desc_nr = -1; + else + rdev->desc_nr = le32_to_cpu(sb->dev_number); + if (refdev == 0) ret = 1; else { @@ -1173,7 +1178,6 @@ static int super_1_validate(mddev_t *mdd } if (mddev->level != LEVEL_MULTIPATH) { int role; - rdev->desc_nr = le32_to_cpu(sb->dev_number); role = le16_to_cpu(sb->dev_roles[rdev->desc_nr]); switch(role) { case 0xffff: /* spare */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |