Messages in this thread |  | | | Date | Mon, 26 Jun 2006 22:49:09 +0200 | | From | Heiko Carstens <> | | Subject | Re: [PATCH] s390: fix duplicate export of overflow{ug}id |
| |
On Mon, Jun 26, 2006 at 02:48:12PM -0500, Serge E. Hallyn wrote: > Quoting Dave Jones (davej@redhat.com): > > On Mon, Jun 26, 2006 at 02:31:41PM -0500, Serge E. Hallyn wrote: > > > overflowuid and overflowgid were exported twice. Remove the export > > > from s390_ksyms.c > > > > There's a gotcha with this. in kernel/sys.c, we only export those > > symbols if CONFIG_UID16 is set. iirc, there was some part of > > arch/s390 that expected to use those symbols even if it wasn't set. > > > > Does everything still link with that option both set and unset ? > > It does on my partition; near as I can tell the only use of overflowuid > is in compat_linux.c, which is always compiled in.
arch/s390/kernel/binfmt_elf32.c which can be build as a module uses this too. But only with the two NEW_TO_OLD_UID and NEW_TO_OLD_GID defines which seem to be unused and could be removed as well. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |