lkml.org 
[lkml]   [2006]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] RTC: add rtc-ds1553 and rtc-ds1742 driver
    On Fri, 23 Jun 2006 18:28:28 +0900 (JST)
    Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:

    > > > +static int ds1553_rtc_ioctl(struct device *dev, unsigned int cmd,
    > > > + unsigned long arg)
    > > > +{
    > > > + struct platform_device *pdev = to_platform_device(dev);
    > > > + struct rtc_plat_data *pdata = platform_get_drvdata(pdev);
    > > > +
    > > > + if (pdata->irq < 0)
    > > > + return -ENOIOCTLCMD;
    > >
    > > inappropriate -Exxx . maybe -ENODEV?.
    >
    > No, it is intentional. If irq is not available, I want to fall back
    > into emulation in rtc-dev.c.

    maybe you can add a comment explaining this choice

    --

    Best regards,

    Alessandro Zummo,
    Tower Technologies - Turin, Italy

    http://www.towertech.it

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-06-25 11:58    [W:0.029 / U:0.816 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site