lkml.org 
[lkml]   [2006]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 22/61] lock validator: add per_cpu_offset()

* Andrew Morton <akpm@osdl.org> wrote:

> > +#define per_cpu_offset(x) (__per_cpu_offset(x))
> > +
> > /* Separate out the type, so (int[3], foo) works. */
> > #define DEFINE_PER_CPU(type, name) \
> > __attribute__((__section__(".data.percpu"))) __typeof__(type) per_cpu__##name
>
> I can tell just looking at it that it'll break various builds.I assume
> that things still happen to compile because you're presently using it
> in code which those architectures don't presently compile.
>
> But introducing a "generic" function invites others to start using it.
> And they will, and they'll ship code which "works" but is broken,
> because they only tested it on x86 and x86_64.
>
> I'll queue the needed fixups - please check it.

[belated reply] They look good.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-23 11:38    [W:0.108 / U:1.720 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site