lkml.org 
[lkml]   [2006]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] mm: tracking shared dirty pages -v10
    From
    Date
    On Fri, 2006-06-23 at 15:35 -0700, Linus Torvalds wrote:
    > On Sat, 24 Jun 2006, Peter Zijlstra wrote:
    >
    > > > > + if ((pgprot_val(vma->vm_page_prot) == pgprot_val(vm_page_prot) &&
    > > > > + ((vm_flags & (VM_WRITE|VM_SHARED|VM_PFNMAP|VM_INSERTPAGE)) ==
    > > > > + (VM_WRITE|VM_SHARED)) &&
    > > > > + vma->vm_file && vma->vm_file->f_mapping &&
    > > > > + mapping_cap_account_dirty(vma->vm_file->f_mapping)) ||
    > > > > + (vma->vm_ops && vma->vm_ops->page_mkwrite))
    > > > > + vma->vm_page_prot =
    > > > > + protection_map[vm_flags & (VM_READ|VM_WRITE|VM_EXEC)];
    > > > > +
    > > >
    > > > I'm dazzled by the beauty of it!
    > >
    > > It's a real beauty isn't it :-)
    >
    > Since Hugh pointed that out..
    >
    > It really would be nice to just encapsulate that as an inline function of
    > its own, and move the comment at the top of it to be at the top of the
    > inline function.

    Dang, I just send out -v11, awell such is life. I'll see what I can do.
    Preferably mprotect can reuse that same function.

    Will repost a new 1/5 shortly.

    Peter

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-06-24 00:46    [W:3.257 / U:0.768 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site