Messages in this thread | | | Date | Fri, 23 Jun 2006 15:45:30 +0100 | From | Christoph Hellwig <> | Subject | Re: GFS2 and DLM |
| |
> The part where you needed file_read_actor looks like pretty much a stright > cut and paste from __generic_file_aio_read, which indicates that you might > be exporting at the wrong level.
A definitive NACK to this export. All other filesystems manage to use the generic file read code so GFS should do so aswell. And there's a technical reason for not exporting aswell as the generic file read interface is far too complicated already.
> Not sure about the tty_ export. Would it be better to make a generic > printfish interface on top of it and also replace the interesting dquot.c > gymnastics? (I don't know)
In fact neither gfs nor dquot should use it at all. The xfs quota code is fine without this nonsense. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |