lkml.org 
[lkml]   [2006]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH][RFC] kill TTY_DONT_FLIP
From
Date
Ar Iau, 2006-06-22 am 14:02 -0500, ysgrifennodd Paul Fulghum:
> Kill TTY_DONT_FLIP flag, which is set in n_tty read_chan().
> This flag is only used by the N_TTY line discipline. It was added
> in the 2.1.X development series. Its original purpose seems
> to be protecting the N_TTY read buffer state (tty->read_tail, etc)
> from conflicting access by read_chan (reads from N_TTY read buffer)
> and the flip buffer code (writes to N_TTY read buffer
> via n_tty_receive_buf).
>
> The spin lock tty->read_lock was subsequently added to
> protect the N_TTY read buffer. After reviewing the
> tty code, I see no other state that is protected
> by TTY_DONT_FLIP.

Looks good to me on a first review.

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-23 15:12    [W:0.048 / U:0.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site