Messages in this thread | | | Date | Fri, 23 Jun 2006 13:01:19 +0200 | From | Ingo Molnar <> | Subject | Re: [patch 61/61] lock validator: enable lock validator in Kconfig |
| |
* Roman Zippel <zippel@linux-m68k.org> wrote:
> > +config PROVE_SPIN_LOCKING > > + bool "Prove spin-locking correctness" > > + default y > > Could you please keep all the defaults in a separate -mm-only patch, > so it doesn't get merged?
yep - the default got removed.
> There are also a number of dependencies on DEBUG_KERNEL missing, it > completely breaks the debugging menu.
i have solved this problem in current -mm by making more advanced versions of lock debugging (allocation/exit checks, validator) depend on more basic lock debugging options. All the basic lock debugging options have a DEBUG_KERNEL dependency, which thus gets inherited by the other options as well.
> > +config LOCKDEP > > + bool > > + default y > > + depends on PROVE_SPIN_LOCKING || PROVE_RW_LOCKING || PROVE_MUTEX_LOCKING || PROVE_RWSEM_LOCKING > > This can be written shorter as: > > config LOCKDEP > def_bool PROVE_SPIN_LOCKING || PROVE_RW_LOCKING || PROVE_MUTEX_LOCKING || PROVE_RWSEM_LOCKING
ok, done. (Btw., there's tons of other Kconfig code though that uses the bool + depends syntax though, and def_bool usage is quite rare.)
Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |