Messages in this thread | | | Date | Thu, 22 Jun 2006 18:29:31 +1000 | Subject | Re: Memory corruption in 8390.c ? (was Re: Possible leaks in network drivers) | From | Herbert Xu <> |
| |
On Thu, Jun 22, 2006 at 04:22:22AM -0400, Jeff Garzik wrote: > > >it if needed. Actually, someone should sift through every instance of > >skb_pad on a non-linear skb as they do not fit the reasons why this was > >originally created. > > Non-linear skbs smaller than ETH_ZLEN seem unlikely.
When I was grepping it seems that a few drivers were using it with a length other than ETH_ZLEN. I've just done another grep and here are the potential suspects:
cassini.c starfire.c yellowfin.c
Also, the skb_pad in drivers/s390/net/claw.c didn't check for errors at all.
Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |