Messages in this thread | | | Date | Thu, 22 Jun 2006 23:26:00 +0100 (BST) | From | Mark Underwood <> | Subject | Re: [i2c] [PATCH] I2C bus driver for Philips ARM boards |
| |
--- Greg KH <greg@kroah.com> wrote:
> On Fri, Jun 23, 2006 at 12:17:55AM +0400, Vitaly Wool wrote: > > On 6/22/06, Greg KH <greg@kroah.com> wrote: > > > > > >> +static inline int i2c_pnx_bus_busy(volatile struct i2c_regs *master) > > >> +{ > > >> + long timeout; > > >> + > > >> + timeout = TIMEOUT * 10000; > > >> + if (timeout > 0 && (master->sts & mstatus_active)) { > > > > > >A big hint about this, if you have volatile in your driver, it's > > >wrong... > > > > > > Well, I do remember flames on the subject... Still __raw_readl also uses > > volatile. > > Anyway, I can't disagree that ioreadX-based register access are better. > > Greg, is there anything else I should take care of before re-sending the > > patch, except for the things that you and Ben pointed out? > > Not that I can think of, that would be a good starting point :)
Would it not make sense to call this driver ip3204 or ph_ip3204 or some such seeing as you correctly point out that this is a common Philips IP block and is used in other, non pnx, chips?
I'm also not sure why the register map is in the arch-pnx4008 directory as this will require every chip that has this IP block to have a copy of the file.
Mark
> > thanks, > > greg k-h > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >
___________________________________________________________ Win tickets to the 2006 FIFA World Cup Germany with Yahoo! Messenger. http://advision.webevents.yahoo.com/fifaworldcup_uk/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |