Messages in this thread | | | Date | Fri, 23 Jun 2006 00:16:22 +0200 | From | Alessandro Zummo <> | Subject | Re: [PATCH] RTC: add rtc-ds1553 and rtc-ds1742 driver |
| |
On Fri, 23 Jun 2006 00:19:27 +0900 (JST) Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> Add RTC drivers for the Dallas DS1553 and DS1742 RTC chip. > > Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
please split this into two patches.
> > +config RTC_DRV_DS1553 > + tristate "Dallas DS1553" > + depends on RTC_CLASS > + help > + If you say yes here you get support for the > + Dallas DS1553 timekeeping chip. > + > + This driver can also be built as a module. If so, the module > + will be called rtc-ds1553. > + > config RTC_DRV_DS1672 > tristate "Dallas/Maxim DS1672" > depends on RTC_CLASS && I2C > @@ -96,6 +106,16 @@ config RTC_DRV_DS1672 > This driver can also be built as a module. If so, the module > will be called rtc-ds1672. > > +config RTC_DRV_DS1742 > + tristate "Dallas DS1742" > + depends on RTC_CLASS > + help > + If you say yes here you get support for the > + Dallas DS1742 timekeeping chip. > + > + This driver can also be built as a module. If so, the module > + will be called rtc-ds1742. > +
on which systems will we likely find those twos? no extra depends?
> +static int ds1553_rtc_ioctl(struct device *dev, unsigned int cmd, > + unsigned long arg) > +{ > + struct platform_device *pdev = to_platform_device(dev); > + struct rtc_plat_data *pdata = platform_get_drvdata(pdev); > + > + if (pdata->irq < 0) > + return -ENOIOCTLCMD;
inappropriate -Exxx . maybe -ENODEV?.
--
Best regards,
Alessandro Zummo, Tower Technologies - Turin, Italy
http://www.towertech.it
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |