Messages in this thread | | | Date | Thu, 22 Jun 2006 14:11:57 -0700 | From | Greg KH <> | Subject | Re: [linux-pm] swsusp regression [Was: 2.6.17-mm1] |
| |
On Thu, Jun 22, 2006 at 05:09:43PM -0400, Alan Stern wrote: > On Thu, 22 Jun 2006, Jiri Slaby wrote: > > > > ages. The "bogus requests" are attempts by the user to suspend a USB > > > device (by writing to /sys/devices/.../power/state) without first > > > suspending all its children and interfaces. > > > > > > (This can't happen when doing a global suspend because the PM core > > > iterates through the entire device tree. It matters only for "runtime" or > > > "selective" suspend.) > > > > But everything I did is: > > echo reboot > /sys/power/disk > > echo disk > /sys/power/state > > > > No writing anywhere else. > > You misunderstood. I meant that attempts to suspend a USB device without > first suspending all its children and interfaces can't happen when doing a > global suspend. That's still true. > > Your problem occurred because even though the PM core did _attempt_ to > suspend the new children added by Greg's patch, it didn't _succeed_ > because the patch did not provide suspend or resume methods.
Which because they are virtual "devices" they do not need a suspend or resume method, so not having any is just fine. If we abort because of something like this, the core logic is quite broken...
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |