Messages in this thread | | | Date | Thu, 22 Jun 2006 17:53:17 +0200 | From | Andreas Mohr <> | Subject | Re: [PATCH -mm 6/6] cpu_relax(): ptrace.c coding style fix |
| |
On Thu, Jun 22, 2006 at 09:32:23AM -0500, Nathan Lynch wrote: > Andreas Mohr wrote: > > > > Fix existing cpu_relax() loop to have proper kernel style. > > > > ... > > > @@ -182,9 +182,8 @@ > > if (!write_trylock(&tasklist_lock)) { > > local_irq_enable(); > > task_unlock(task); > > - do { > > + while (!write_can_lock(&tasklist_lock)) > > cpu_relax(); > > - } while (!write_can_lock(&tasklist_lock)); > > This is a change in behavior, not just style. (And there is nothing > wrong with the current style.)
Ick, right, this could cause the new state to be visible in the 2nd iteration only.
Thanks! Discard this change please.
Andreas Mohr - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |