lkml.org 
[lkml]   [2006]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -mm 6/6] cpu_relax(): ptrace.c coding style fix
On Thu, Jun 22, 2006 at 09:32:23AM -0500, Nathan Lynch wrote:
> Andreas Mohr wrote:
> >
> > Fix existing cpu_relax() loop to have proper kernel style.
> >
>
> ...
>
> > @@ -182,9 +182,8 @@
> > if (!write_trylock(&tasklist_lock)) {
> > local_irq_enable();
> > task_unlock(task);
> > - do {
> > + while (!write_can_lock(&tasklist_lock))
> > cpu_relax();
> > - } while (!write_can_lock(&tasklist_lock));
>
> This is a change in behavior, not just style. (And there is nothing
> wrong with the current style.)

Ick, right, this could cause the new state to be visible in the 2nd iteration
only.

Thanks! Discard this change please.

Andreas Mohr
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-22 17:55    [W:0.052 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site