lkml.org 
[lkml]   [2006]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[Patch] Overrun in drivers/char/rio/riocmd.c
    From
    Date
    hi,

    this fixes coverity bug id #1025.
    The code checks if Rup is greater or equal to the size of
    HostP->Mapping[], but uses Rup as an index if it is outside
    the range. This patch changes the if and else cases.

    Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>

    --- linux-2.6.17-git2/drivers/char/rio/riocmd.c.orig 2006-06-21 23:14:52.000000000 +0200
    +++ linux-2.6.17-git2/drivers/char/rio/riocmd.c 2006-06-21 23:15:21.000000000 +0200
    @@ -402,7 +402,7 @@ static int RIOCommandRup(struct rio_info
    rio_dprintk(RIO_DEBUG_CMD, "CONTROL information: Host number %Zd, name ``%s''\n", HostP - p->RIOHosts, HostP->Name);
    rio_dprintk(RIO_DEBUG_CMD, "CONTROL information: Rup number 0x%x\n", rup);

    - if (Rup >= (unsigned short) MAX_RUP) {
    + if (Rup < (unsigned short) MAX_RUP) {
    rio_dprintk(RIO_DEBUG_CMD, "CONTROL information: This is the RUP for RTA ``%s''\n", HostP->Mapping[Rup].Name);
    } else
    rio_dprintk(RIO_DEBUG_CMD, "CONTROL information: This is the RUP for link ``%c'' of host ``%s''\n", ('A' + Rup - MAX_RUP), HostP->Name);

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-06-21 23:20    [W:0.033 / U:0.364 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site