lkml.org 
[lkml]   [2006]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] Implement kasprintf
On Tue, 20 Jun 2006 17:14:55 -0700 Jeremy Fitzhardinge wrote:

> Randy.Dunlap wrote:
> > Why do we want a separate source file for this one function?
> >
> Because if it shared a file with something else, someone would complain
> about it bloating code which doesn't use it... At the moment there are
> no in-tree users (though I'm sure there's something out there with an
> open-coded version of this), but we'll be needing it for Xen.

Doesn't this already add the bloat/code? ::

diff -r c175fd50e604 lib/Makefile
--- a/lib/Makefile Tue Jun 20 16:47:53 2006 -0700
+++ b/lib/Makefile Tue Jun 20 16:53:19 2006 -0700
@@ -5,7 +5,7 @@ lib-y := errno.o ctype.o string.o vsprin
lib-y := errno.o ctype.o string.o vsprintf.o cmdline.o \
bust_spinlocks.o rbtree.o radix-tree.o dump_stack.o \
idr.o div64.o int_sqrt.o bitmap.o extable.o prio_tree.o \
- sha1.o
+ sha1.o kasprintf.o

> I'm happy to fold it into vsprintf.c though.

That makes sense to me.

Thanks,
---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2006-06-21 02:25    [W:0.046 / U:0.252 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site