lkml.org 
[lkml]   [2006]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 01/13] USB: Whiteheat: fix firmware spurious errors
    -stable review patch.  If anyone has any objections, please let us know.
    ------------------

    From: <stuartm@connecttech.com>

    Attached patch fixes spurious errors during firmware load.

    Signed-off-by: Stuart MacDonald <stuartm@connecttech.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    ---
    drivers/usb/serial/whiteheat.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- linux-2.6.16.21.orig/drivers/usb/serial/whiteheat.c
    +++ linux-2.6.16.21/drivers/usb/serial/whiteheat.c
    @@ -388,7 +388,7 @@ static int whiteheat_attach (struct usb_
    if (ret) {
    err("%s: Couldn't send command [%d]", serial->type->description, ret);
    goto no_firmware;
    - } else if (alen != sizeof(command)) {
    + } else if (alen != 2) {
    err("%s: Send command incomplete [%d]", serial->type->description, alen);
    goto no_firmware;
    }
    @@ -400,7 +400,7 @@ static int whiteheat_attach (struct usb_
    if (ret) {
    err("%s: Couldn't get results [%d]", serial->type->description, ret);
    goto no_firmware;
    - } else if (alen != sizeof(result)) {
    + } else if (alen != sizeof(*hw_info) + 1) {
    err("%s: Get results incomplete [%d]", serial->type->description, alen);
    goto no_firmware;
    } else if (result[0] != command[0]) {
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-06-20 13:51    [W:4.177 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site