Messages in this thread | | | Date | Mon, 19 Jun 2006 19:56:51 +0100 | From | Christoph Hellwig <> | Subject | Re: [RFC] [PATCH 5/8] inode-diet: Eliminate i_blksize and use a per-superblock default |
| |
On Mon, Jun 19, 2006 at 01:03:38PM -0400, Theodore Tso wrote: > I was mainly adding a field to the superblock for the sake of > reiserfs; it was the easiest way to support it's current insanity of > reporting 128megs as st_blksize, but with a mount option that affected > things on a global scale. (Hey, at least my patch made resierfs > support the mount option as a per-superblock setting, instead of > setting a global variable that changed the behaviour for all mounts.) > > I don't mind espceially removing the superblock field, but if we do, I > refuse to mess with adding a getattr special for reiserfs; someone who > wants to support its current behaviour is free to send me or LKML > patches....
I'd suggest to either keep their current buggy behaviour and let Hans fix it or use a field in the reiserfs specific superblock structure. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |