lkml.org 
[lkml]   [2006]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: 2.6.17: CONFIG_PARPORT_SERIAL should require CONFIG_SERIAL_8250_PCI?
Date
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 18 June 2006 16:05, Russell King wrote:
> On Sun, Jun 18, 2006 at 02:23:07PM +0400, Andrey Borzenkov wrote:
> > Just rebuilt 2.6.17 from older config and disabling 8250 PCI (I do not
> > have any on notebook) and got:
>
> Thanks for reporting this. The patch below should fix this - please
> test so it can be submitted for the stable branch, thanks.
>

I confirm that with this patch doing oldconfig and deselecting SERIAL_8250_PCI
also deselects PARPORT_SERIAL.

regards

- -andrey

> # Base git commit: 427abfa28afedffadfca9dd8b067eb6d36bac53f
> # (Linux v2.6.17)
> #
> # Author: Russell King (Sun Jun 18 13:00:48 BST 2006)
> # Committer: Russell King (Sun Jun 18 13:00:48 BST 2006)
> #
> # [SERIAL] PARPORT_SERIAL should depend on SERIAL_8250_PCI
> #
> # Since parport_serial uses symbols from 8250_pci, there should
> # be a dependency between the configuration symbols for these
> # two modules. Problem reported by Andrey Borzenkov
> #
> # Signed-off-by: Russell King
> #
> # drivers/parport/Kconfig | 2 +-
> # 1 files changed, 1 insertions(+), 1 deletions(-)
> #
> diff --git a/drivers/parport/Kconfig b/drivers/parport/Kconfig
> --- a/drivers/parport/Kconfig
> +++ b/drivers/parport/Kconfig
> @@ -48,7 +48,7 @@ config PARPORT_PC
>
> config PARPORT_SERIAL
> tristate "Multi-IO cards (parallel and serial)"
> - depends on SERIAL_8250 && PARPORT_PC && PCI
> + depends on SERIAL_8250_PCI && PARPORT_PC && PCI
> help
> This adds support for multi-IO PCI cards that have parallel and
> serial ports. You should say Y or M here. If you say M, the module
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)

iD8DBQFElXEzR6LMutpd94wRAh5PAKC7rNyFMqogQPGgYYixgK14M6hwcgCgs8h8
IqQIn2z447RBjQGLXM00iog=
=Tisv
-----END PGP SIGNATURE-----
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-18 17:31    [W:0.038 / U:1.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site