lkml.org 
[lkml]   [2006]   [Jun]   [18]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
    /
    DateSat, 17 Jun 2006 22:58:13 -0700
    FromAndrew Morton <>
    SubjectRe: [patch 2/3] vdso: improve print_fatal_signals support by adding memory maps
    On Sat, 17 Jun 2006 21:58:18 -0700
    "Randy.Dunlap" <rdunlap@xenotime.net> wrote:
    
    > On Sat, 17 Jun 2006 16:14:52 +0200 Simon Raffeiner wrote:
    > 
    > > When compiling 2.6.17-rc6-mm2 (which contains this patch) my gcc 4.0.3 (Ubuntu 
    > > 4.0.3-1ubuntu5) complains about "int len;" being used uninitialized in 
    > > print_vma(). AFAICS len is not initialized and then passed to 
    > > pad_len_spaces(int len), which uses it for some calculations.
    > > 
    > > I also noticed that similar code is used in fs/proc/task_mmu.c, where 
    > > show_map_internal() passes an uninitialised int len; to pad_len_spaces(struct 
    > > seq_file *m, int len).
    > 
    > Ack both of those.  And both of them pass &len as a parameter to
    > printk/seq_printf where it looks as though they want just <len>
    > (after it has been initialized).
    > 
    
    printk("%n", &len) will initialise `len'.  gcc is being wrong again.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    
    
    \
     
     \ /
      Last update: 2006-06-18 08:00    [from the cache]
    ©2003-2008