lkml.org 
[lkml]   [2006]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[RFC][PATCH 13/20] elevate writer count for do_sys_truncate()
    From
    Date


    Signed-off-by: Dave Hansen <haveblue@us.ibm.com>
    ---

    lxc-dave/fs/open.c | 16 +++++++++++-----
    1 files changed, 11 insertions(+), 5 deletions(-)

    diff -puN fs/open.c~C-elevate-writers-opens-part2-do_sys_truncate fs/open.c
    --- lxc/fs/open.c~C-elevate-writers-opens-part2-do_sys_truncate 2006-06-16 15:58:07.000000000 -0700
    +++ lxc-dave/fs/open.c 2006-06-16 15:58:07.000000000 -0700
    @@ -244,28 +244,32 @@ static long do_sys_truncate(const char _
    if (!S_ISREG(inode->i_mode))
    goto dput_and_out;

    - error = vfs_permission(&nd, MAY_WRITE);
    + error = mnt_want_write(nd.mnt);
    if (error)
    goto dput_and_out;

    + error = vfs_permission(&nd, MAY_WRITE);
    + if (error)
    + goto mnt_drop_write_and_out;
    +
    error = -EROFS;
    if (IS_RDONLY(inode))
    - goto dput_and_out;
    + goto mnt_drop_write_and_out;

    error = -EPERM;
    if (IS_IMMUTABLE(inode) || IS_APPEND(inode))
    - goto dput_and_out;
    + goto mnt_drop_write_and_out;

    /*
    * Make sure that there are no leases.
    */
    error = break_lease(inode, FMODE_WRITE);
    if (error)
    - goto dput_and_out;
    + goto mnt_drop_write_and_out;

    error = get_write_access(inode);
    if (error)
    - goto dput_and_out;
    + goto mnt_drop_write_and_out;

    error = locks_verify_truncate(inode, NULL, length);
    if (!error) {
    @@ -274,6 +278,8 @@ static long do_sys_truncate(const char _
    }
    put_write_access(inode);

    +mnt_drop_write_and_out:
    + mnt_drop_write(nd.mnt);
    dput_and_out:
    path_release(&nd);
    out:
    _
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-06-17 01:16    [W:0.027 / U:1.708 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site