lkml.org 
[lkml]   [2006]   [Jun]   [15]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateThu, 15 Jun 2006 07:28:07 +0200
FromIngo Molnar <>
SubjectRe: [patch] ipv4: fix lock usage in udp_ioctl
* Herbert Xu <herbert@gondor.apana.org.au> wrote:

> This is bogus.  These two locks belong to two different queues and 
> they never intersect.

yeah - qeth does its own skb-queue management here, and it's done in an 
irq-safe manner.

Heiko, in qeth_main.c, could you do something like:

+ static struct lockdep_type_key qdio_out_skb_queue_key;

...
		skb_queue_head_init(&card->qdio.out_qs[i]->bufs[j].
				     skb_list);
+		lockdep_reinit_key(&card->qdio.out_qs[i]->bufs[j].skb_list,
				   &qdio_out_skb_queue_key)

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-06-15 07:32    [from the cache]
©2003-2008