Messages in this thread |  | | | Date | Fri, 16 Jun 2006 08:42:20 +1000 | | From | Paul Mackerras <> | | Subject | Re: [PATCH]: powerpc: pseries: Print PCI slot location code on failure |
| |
Linas Vepstas writes:
> Resending an older patch (from 28 April) that seems to have fallen > through the cracks, its not in mailine, is not in -mm and its not > controversial (its mostly a printk change). Tested.
I don't like doing printk on things that might be NULL (i.e. the result of get_property). Even though printk doesn't crash, it would be nicer for the user to see "location=unknown" or something rather than "location=<NULL>".
Paul. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |