Messages in this thread | | | Date | Wed, 14 Jun 2006 17:53:08 -0700 | From | Pete Zaitcev <> | Subject | Re: Serial-Core: USB-Serial port current issues. |
| |
On Wed, 14 Jun 2006 17:38:24 -0300, "Luiz Fernando N. Capitulino" <lcapitulino@mandriva.com.br> wrote:
> I think BUG_ON(in_interrupt()) does the job. I'll try it here, and > if it doesn't trigger I'll submit a patch to Andrew only for > testing porpuses (ie, not for mainline).
Luiz, you can't be serious! You have to do a review and write call paths on a piece of paper or however you prefer to do it. Your testing is extremely limited as we know, you don't even have a null-modem cable. So if the patch does not trip in your testing it tells you absolutely nothing. But even in context of AKPM's tree you can't rely on run-time checks to pick this sort of things.
And putting a BUG in there is irresponsible too. It's such a critical subsystem. Drop bytes or return zero modem lines, but do not bug out.
-- Pete - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |