lkml.org 
[lkml]   [2006]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2.6.17-rc6 7/9] Remove some of the kmemleak false positives
    Hi Catalin,

    On Tue, 13 Jun 2006, Catalin Marinas wrote:
    > The gc roots are the data and bss sections (and maybe task kernel
    > stacks) and all the slab-allocated blocks are scanned if a link to
    > them is found from the roots (and all of them are usually scanned). If
    > no link is found, they would be reported as memory leaks (and not
    > scanned). You can't really avoid the scanning of allocated blocks
    > since they may contain pointers to other blocks.

    I am not sure you're agreeing or disagreeing :-). As far as I understood,
    Ingo is worried about:

    struct s { /* some fields */; char *buf; };

    struct s *p = kmalloc(sizeof(struct s) + BUF_SIZE);
    p->buf = p + sizeof(struct s);

    Which could lead to false negative due to p->buf pointing to p. However,
    for us to even _find_ p->buf, we would need an incoming pointer _to_ p
    which makes me think this is not a problem in practice. Hmm?

    Pekka
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-06-13 10:00    [W:3.041 / U:0.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site