Messages in this thread | | | Date | Mon, 12 Jun 2006 19:15:41 -0400 | From | Mark Lord <> | Subject | Re: pl2303 ttyUSB0: pl2303_open - failed submitting interrupt urb, error -28 |
| |
Greg KH wrote: > On Mon, Jun 12, 2006 at 06:12:58PM -0400, Mark Lord wrote: .. >> Eg. If usb_submit_urb() ever fails again (low on memory, etc..) >> inside pl2303_open(), will we be back with the same bug? >> >> What's the *real* actual bug here? > > There are two of them. > > The fact that the urb submission in the pl2303 driver fails, and is now > handled properly is fixed in the pl2303 patch. > > The fact that we can (hopefully) handle scheduling TT in the EHCI driver > fixes the real problem with plugging slow or full speed devices into a > USB 2.0 hub (not root hub). That's fixed by the tt patch. > > So we should have finally covered both of them now.
Yes, agreed.
So if modify pl2303_open() to have it simulate -ENOMEM from usb_submit_urb(), then this should not crash the entire USB subsystem. Right?
Ditto if it happens due to low-memory, rather than me hacking the code to test it?
Cheers - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |