Messages in this thread Patch in this message | | | Date | Sun, 11 Jun 2006 20:43:18 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 4/5] readahead: backoff on I/O error |
| |
On Mon, 12 Jun 2006 09:12:45 +0800 Wu Fengguang <wfg@mail.ustc.edu.cn> wrote:
> Andrew: > I was a bit afraid about that because I have no CDROM to try it out. > But since Michael has tested it OK, it should be OK for the stable kernel.
hm. It's a problem, but not a terribly huge one.
It's nice to print the filename, but we shouldn't use d_iname because long filenames aren't stored there. And if the file was unlinked after open then I don't think we'll oops, but the filename isn't very meaningful.
So...
--- devel/mm/filemap.c~readahead-backoff-on-i-o-error-tweaks 2006-06-11 20:40:52.000000000 -0700 +++ devel-akpm/mm/filemap.c 2006-06-11 20:41:05.000000000 -0700 @@ -804,8 +804,7 @@ static void shrink_readahead_size_eio(st return; ra->ra_pages /= 4; - printk(KERN_WARNING "Retracting readahead size of %s to %luK\n", - filp->f_dentry->d_iname, + printk(KERN_WARNING "Reducing readahead size to %luK\n", ra->ra_pages << (PAGE_CACHE_SHIFT - 10)); } _ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |