lkml.org 
[lkml]   [2006]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kthread conversion: convert ieee1394 from kernel_thread
Christoph Hellwig wrote:
> On Sat, Jun 10, 2006 at 09:31:00AM -0500, Serge E. Hallyn wrote:
>
>>Convert ieee1394 from using deprecated kernel_thread to
>>kthread api.
>>
>>Compiles fine, but unfortunately I am unable to test.
>
>
> This patch does various things wrong or at least suboptimal. See
> '[PATCH] ieee1394_core: switch to kthread API' sent to the ieee1394-devel
> list on the 14th of April for a patch the gets the formalisms right,
> although I wasn't able to test it either.

The patch Christoph is referring to, together with a small fix by Andrew
Morton, is in -mm and is IMO ready to go into Linux 2.6.18. However this
patch converts only the khpsbpkt (packet/ transactions handler), not the
knodemgrd (bus management and protocol driver dispatcher).

Serge, could you reduce your patch to the nodemgr part and resubmit? A
diff against current -mm would be most welcome. If you develop on top of
Linus' tree, you could get current 1394 subsystem code which is almost
identical to latest -mm here:
http://me.in-berlin.de/~s5r6/linux1394/updates/
Thanks,
--
Stefan Richter
-=====-=-==- -==- -=-=-
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2006-06-10 17:17    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site