Messages in this thread |  | | | Date | Sat, 10 Jun 2006 16:29:45 -0700 | | From | "Randy.Dunlap" <> | | Subject | Re: [PATCH] jffs2: fix section mismatches |
| |
On Sat, 10 Jun 2006 23:00:17 +0100 David Woodhouse wrote:
> On Sat, 2006-06-10 at 13:28 -0700, Randy.Dunlap wrote: > > Priority: not critical; makes init code discardable. > > > > Fix section mismatch warnings: > > WARNING: fs/jffs2/jffs2.o - Section mismatch: reference > > to .init.text:jffs2_zlib_init from .text between > > 'jffs2_compressors_init' (at offset 0x546) and > > 'jffs2_compressors_exit' > > Some of this is already in -mm, isn't it?
Ack, one of them is, yes. Sorry I missed it.
> I'm wary of this kind of change from drive-by patchers now -- I had to > commit two fixes recently to remove __exit from functions which are > actually called in the error case from the init function.
Surely those would have been caught with the modpost checker, if the patch submitter(s) used it... ?? FWIW, I check the ones that I submit very carefully, but I too can make mistakes.
> For those exit-and-error functions, I think we actually want an > __initexit marker. In the built-in case, it can actually be discarded > with the init code. In the modular case, it needs to be kept.
That sounds good, yes.
--- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |