Messages in this thread | | | Date | Thu, 1 Jun 2006 02:46:11 -0700 | From | Rajesh Shah <> | Subject | Re: [BUG](-mm)pci_disable_device function clear bars_enabled element |
| |
On Thu, Jun 01, 2006 at 03:05:50PM +0800, bibo,mao wrote: > I found that in -mm tree, function pci_disable_device() > clears bars_enabled variable, so that pci_release_regions > can not release reserved PCI I/O and memory resource. Some > device driver programs in kernel tree call pci_release_regions > function after pci_disable_device(), that will cause some problem.
It's coming from Kaneshige-san's patch: pci-legacy-i-o-port-free-driver-changes-to-generic-pci-code.patch
This patch assumes that pci_request_region() will always be called after pci_enable_device() and pci_release_region() will always be called before pci_disable_device(). We cannot make this assumption,since it's perfectly legal to disable a device first and then release it's regions. So, I think that patch needs to change.
thanks, Rajesh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |