lkml.org 
[lkml]   [2006]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch mm1-rc2] lock validator: netlink.c netlink_table_grab fix
    On Tue, May 30, 2006 at 11:14:15AM +0200, Benoit Boissinot wrote:
    > On 5/29/06, Ingo Molnar <mingo@elte.hu> wrote:
    > >We are pleased to announce the first release of the "lock dependency
    > >correctness validator" kernel debugging feature, which can be downloaded
    > >from:
    > >
    > > http://redhat.com/~mingo/lockdep-patches/
    > >[snip]
    >
    > I get this right after ipw2200 is loaded (it is quite verbose, I
    > probably shoudln't post everything...)
    >
    This got rid of the oops for me, is it the right fix?

    Signed-off-by: Frederik Deweerdt <frederik.deweerdt@gmail.com>
    --- /usr/src/linux/net/netlink/af_netlink.c 2006-05-24 14:58:38.000000000 +0200
    +++ net/netlink/af_netlink.c 2006-06-01 16:36:51.000000000 +0200
    @@ -157,7 +157,7 @@ static void netlink_sock_destruct(struct

    static void netlink_table_grab(void)
    {
    - write_lock_bh(&nl_table_lock);
    + write_lock_irq(&nl_table_lock);

    if (atomic_read(&nl_table_users)) {
    DECLARE_WAITQUEUE(wait, current);
    @@ -167,9 +167,9 @@ static void netlink_table_grab(void)
    set_current_state(TASK_UNINTERRUPTIBLE);
    if (atomic_read(&nl_table_users) == 0)
    break;
    - write_unlock_bh(&nl_table_lock);
    + write_unlock_irq(&nl_table_lock);
    schedule();
    - write_lock_bh(&nl_table_lock);
    + write_lock_irq(&nl_table_lock);
    }

    __set_current_state(TASK_RUNNING);
    @@ -179,7 +179,7 @@ static void netlink_table_grab(void)

    static __inline__ void netlink_table_ungrab(void)
    {
    - write_unlock_bh(&nl_table_lock);
    + write_unlock_irq(&nl_table_lock);
    wake_up(&nl_table_wait);
    }

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-06-01 16:49    [W:0.063 / U:15.884 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site