lkml.org 
[lkml]   [2006]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fs: fcntl_setlease defies lease_init assumptions
On Tue, 9 May 2006, Linus Torvalds wrote:

> Right now the __cache_free() chain does "virt_to_page()" on NUMA
> regardless, through the
>
> #ifdef CONFIG_NUMA
> {
> struct slab *slabp;
> slabp = virt_to_slab(objp);
> ,,,
>
> thing. The suggested patch obviously makes it do it _twice_: once to get
> the cachep, once to get the slabp. But some simple re-organization would
> make it do it just once, if we passed in the "struct page *" instead of
> the "struct cachep" - since in the end, every single path into the real
> core of the allocator does end up needing it.

Sounds like the best approach to address this rather than another slab
redesign.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-10 02:02    [W:0.095 / U:16.096 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site