lkml.org 
[lkml]   [2006]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] swiotlb: create __alloc_bootmem_low_nopanic and add support in SWIOTLB
On Tue, May 09, 2006 at 02:04:08PM -0700, Luck, Tony wrote:
> > I "fixed" it with the hack below. Please let me know if this is not
> > palatable for you.
>
> Not really. The only use of platform_dma_init() that I can see is in
> arch/ia64/mm/init.c:mem_init() ...
>
> platform_dma_init();
>
> so "void" looks to be the right return value. Why did it get changed to
> be "int" (here's where I admit that I've only looked superficially at your
> patch).

Ah, then I better describe it. The patch makes it possible to recover
from an insufficient amount of bootmem during swiotlb_init (instead of
panicing). For x86_64, I have it bailing out (via the returned int from
swiotlb_init and using the non-iommu DMA routines from
arch/x86_64/kernel/pci-nommu.c). For ia64, its not that simple.
There are no alternative DMA routines to switch to incase of an error.
Also, There is no way to "bail-out" from its mem_init. I could add a
panic there, if that is more palatable.

Thanks,
Jon

>
> -Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-09 23:29    [W:0.025 / U:0.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site