lkml.org 
[lkml]   [2006]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 15/35] subarch support for controlling interrupt delivery
Martin J. Bligh wrote:
>> +/*
>> + * The use of 'barrier' in the following reflects their use as
>> local-lock
>> + * operations. Reentrancy must be prevented (e.g., __cli()) /before/
>> following
>> + * critical operations are executed. All critical operations must
>> complete
>> + * /before/ reentrancy is permitted (e.g., __sti()). Alpha
>> architecture also
>> + * includes these barriers, for example.
>> + */
>
>
> Seems like an odd comment to have in an i386 header file.

Also, it is only talking about compiler barriers, which have nothing
to do with the architecture.

And preempt_* macros should contain the correct compiler barriers, so
several can be removed.

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-09 21:25    [W:3.005 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site