Messages in this thread | | | Date | Wed, 10 May 2006 00:55:01 +1000 | From | Nick Piggin <> | Subject | Re: [RFC PATCH 15/35] subarch support for controlling interrupt delivery |
| |
Martin J. Bligh wrote: >> +/* >> + * The use of 'barrier' in the following reflects their use as >> local-lock >> + * operations. Reentrancy must be prevented (e.g., __cli()) /before/ >> following >> + * critical operations are executed. All critical operations must >> complete >> + * /before/ reentrancy is permitted (e.g., __sti()). Alpha >> architecture also >> + * includes these barriers, for example. >> + */ > > > Seems like an odd comment to have in an i386 header file.
Also, it is only talking about compiler barriers, which have nothing to do with the architecture.
And preempt_* macros should contain the correct compiler barriers, so several can be removed.
-- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |