Messages in this thread | | | Subject | Re: [RFC PATCH 00/35] Xen i386 paravirtualization support | From | Andi Kleen <> | Date | 09 May 2006 17:20:11 +0200 |
| |
Christoph Hellwig <hch@infradead.org> writes:
> On Tue, May 09, 2006 at 07:49:37AM -0700, Martin J. Bligh wrote: > > Congrats on getting this thrashed out. A few comments, most of which are > > boring style nits, but nonetheless ... will try to take a proper look > > later. > > > > General comment: > > > > Why is this style used: > > > > HYPERVISOR_foo_bar ? > > > > ie the capitalization of HYPERVISOR. Doesn't seem to fit with the rest > > of the kernel style. > > It's also wrong. There's more than one hypervisor and Xen shouldn't just > grab this namespace. make it xen_ or xenhv_.
You should reject the recent "hypervisor file system" with the same argument then.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |