lkml.org 
[lkml]   [2006]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] fix can_share_swap_page() when !CONFIG_SWAP
    On Mon, 8 May 2006, Nick Piggin wrote:
    > Hua Zhong wrote:
    > >
    > >I'm not sure if it's the best fix. Maybe we should rename
    > >can_share_swap_page() and move it out of swapfile.c. Comments?
    >
    > Looks like a good patch, nice catch. You should run it past Hugh but tend to
    > agree it would be nice to reuse the out of line can_share_swap_page, which
    > would fold beautifully with PageSwapCache a constant 0.

    True; but I think Hua's patch is good as is for now, to fix
    that inefficiency. I do agree (as you know) that there's scope for
    cleanup there, and that that function is badly named; but I'm still
    unprepared to embark on the cleanup, so let's just get the fix in.

    Hugh
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-05-08 14:47    [W:0.024 / U:28.928 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site